Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIN-729 persist device ids. #861

Merged
merged 6 commits into from
Dec 20, 2022
Merged

LIN-729 persist device ids. #861

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
643e0d8
persist device id so that we dont keep getting new random numbers (a …
lionsardesai Dec 16, 2022
ce75bc2
black fix
lionsardesai Dec 17, 2022
a56fa03
try to fix the erroneous run on github
lionsardesai Dec 19, 2022
6bfd46d
Revert "try to fix the erroneous run on github"
lionsardesai Dec 19, 2022
56fd8fc
a more targeted fix for the github issue. (lru cache isnt getting res…
lionsardesai Dec 19, 2022
6ee2955
fix duplicated line. [skip-ci]
lionsardesai Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
black fix
  • Loading branch information
@lionsardesai
lionsardesai committed Dec 17, 2022
commit ce75bc2313b146ec50ffb2eb84ae91cfd2017653
2 changes: 1 addition & 1 deletion lineapy/utils/analytics/usage_tracking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def _device_id() -> str:
# numbers as well however the only case discussed when that happens is in android where it
# does not have permissions to access macids. This seems to happen in more cases as we have
# observed more device ids for the same user than we expected. To fix this, we'll persist
# an id to the .lineapy folder for future use. This might give us a bit more stability
# an id to the .lineapy folder for future use. This might give us a bit more stability

device_id = ""
with open(options.safe_get("dev_id"), "w+") as f:
Expand Down