Add pipeline run tests for DVC #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pd-t
reviewed
Jan 10, 2023
dvc-requirements.txt
Outdated
| @@ -0,0 +1,4 @@ | |||
| dvc==2.38.1 | |||
| pandas | |||
There was a problem hiding this comment.
Could we install the additional packages (panda, scikit-learn and SQLAlchemy) using the pipeline generated requirements file? As additional virtualenv.run() command after 'git init' and 'dvc init'?
|
@andycui97 I'm fine with the changes, I think the comment above is obsolete! |
Sg! Just waiting on @aayan636 to review internally as well. |
aayan636
requested changes
Jan 11, 2023
aayan636
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tests for DVC pipelines to test that they actually run in tests/test_pipeline_run_dvc.py.
Aldo changes default flavor for DVC to be StagePerArtifact.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?