Code review of lib_metadata_db codebase

[kallewesterling]

(This issue was originally intended as a submission to the DH Code process for code review)

[griff-rees]

A starting point (of potential tickets...).

• Not sure how the django_initialiser module is used. I can see the value of its __init__.py in some contexts but wondering if those are still applicable.
• Potential refactoring folder structure
• GeoDjango should be available since 699a063. Does it make sense to add a PointField to Place in Gazetteer and a MultiPolygonField to Census Record

[griff-rees]

Might be worth having a peak at this @kallewesterling: maybe helpful agenda for a meeting. A significant refactor is done.

[kallewesterling]

Sorry @griff-rees - I had missed your comment here.

Re: this

Not sure how the django_initialiser module is used. I can see the value of its init.py in some contexts but wondering if those are still applicable.

It is needed to load Django inside of a Jupyter notebook. We used it this summer to make sure that django is correctly set up, etc. in the top line of the notebook:

import django_initialiser

Ideally, we'd have instructions for how to do this more explicitly for folks who want to work with Jupyter Notebooks/Lab + the metadata db eventually... It was just a shortcut so I wouldn't have to spend time on it this past summer.

[griff-rees]

Thanks @kallewesterling and sorry for not replying sooner. I think this form is what's necessary for this: https://docs.google.com/forms/d/e/1FAIpQLSeFLFSS2NEttNimGo-lZmDiSjWzcoefV8GojEZGHPd-YVtBkQ

[griff-rees]

I've created ticket #171 to address the first element on my list in the comment above