Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Opsi Safe Star Objective Farming #2679

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

guoh064
Copy link
Contributor

@guoh064 guoh064 commented May 31, 2023

#1682 刷取安全海域成就星的一个实现。
目前还没有特别想好要不要特判最后一天不领取奖励(防止打不完,领取奖励之后是否要调用深渊海域和秘密海域)
目前设置为每月最后一天不领取奖励。任务优先级排在大世界商店之后,深渊海域之前(因为领取的奖励可能包括坐标)

@guoh064

This comment was marked as resolved.

module/os_handler/target.py Outdated Show resolved Hide resolved
module/os/operation_siren.py Outdated Show resolved Hide resolved
@LmeSzinc LmeSzinc added the feature request / 功能请求 New feature or requests label Jun 9, 2023
@guoh064

This comment was marked as resolved.

@guoh064 guoh064 requested a review from LmeSzinc June 16, 2023 15:15
@guoh064

This comment was marked as resolved.

module/os_handler/target.py Outdated Show resolved Hide resolved
module/os_handler/target.py Outdated Show resolved Hide resolved
module/os_handler/target.py Outdated Show resolved Hide resolved
@LmeSzinc
Copy link
Owner

需要解决合并冲突

@guoh064 guoh064 changed the base branch from master to dev June 23, 2023 08:10
@guoh064

This comment was marked as resolved.

@LmeSzinc
Copy link
Owner

还是与短猫任务合并吧,作为行动力消耗的统一任务,不成为单独的任务。短猫本身的指定海域功能也可以考虑移除,替换成打成就星星的开关。

@guoh064

This comment was marked as resolved.

@guoh064 guoh064 force-pushed the os_collective branch 2 times, most recently from 424fa36 to d410307 Compare June 30, 2023 10:02
@guoh064
Copy link
Contributor Author

guoh064 commented Jun 30, 2023

@LmeSzinc rebase到最新的master上面了

目前拆分出run()receive_reward()两个主要的函数:

  • receive_reward()插在大世界每日的最后执行。开关开启时,每个月除最后一天外收取海域成就奖励;
  • run()插在短猫任务中间(如有必要也保留写成任务),每天第一次运行到代码段时执行。开关开启时,检查下一个可以刷的安全海域;

@guoh064 guoh064 force-pushed the os_collective branch 3 times, most recently from bfbea49 to 0b46910 Compare June 30, 2023 10:45
@LmeSzinc
Copy link
Owner

整体是没有问题的

  1. 我注意到 assets 复制到了所有的服务器上了,他们都是通用的吗?通用的复制给所有服务器,需要适配的留着缺漏,不然不知道哪些需要适配
  2. 对于还没有适配的服务器硬编码无视这个设置

@guoh064

This comment was marked as resolved.

@guoh064

This comment was marked as outdated.

@bookbug666
Copy link
Contributor

啊.....但是我也是日服

@guoh064
Copy link
Contributor Author

guoh064 commented Jul 22, 2023

啊.....但是我也是日服

啊这,谁是国服主力玩家来着(忘了)

@bookbug666
Copy link
Contributor

As for EN server, i suggest ask @nEEtdo0d for help
美服號丟了沒法幫只能@人了

@guoh064

This comment was marked as resolved.

@guoh064 guoh064 force-pushed the os_collective branch 2 times, most recently from d6b8216 to 55943d9 Compare August 4, 2023 05:05
@guoh064
Copy link
Contributor Author

guoh064 commented Dec 26, 2023

整体是没有问题的

  1. 我注意到 assets 复制到了所有的服务器上了,他们都是通用的吗?通用的复制给所有服务器,需要适配的留着缺漏,不然不知道哪些需要适配
  2. 对于还没有适配的服务器硬编码无视这个设置

已处理

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request / 功能请求 New feature or requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants