[pull] main from bloomberg:main #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
To make the README more eye-catchy, add an animated version of the live mode at the top of the section about the live mode.
We missed removing this after some refactoring. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
These calls are no longer doing anything useful now that FileReader calls `_populate_allocations` in its `__cinit__`. We missed removing these calls after a previous refactoring made them no-ops. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
Stop making the RecordReader hold a collection of previously seen allocation records and memory records. Instead, have it store only the most recently seen of each. For now, we'll just save the records in the FileReader, but this refactoring clears the way for us to do something more memory efficient. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
In exactly one place the `getHighWatermark` function went back to look at a previously seen allocation, and only to get its size. Instead of keeping a reference to the allocation and using that to look up its size later, just save its size in the first place. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
Previously we were requiring access to all allocations simultaneously. This refactoring lays some ground work for us to be able to process a capture file without holding all its allocations in memory simultaneously. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
Previously this was exposed as a separate property, rather than as part of the metadata that all other header fields are exposed through. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
We are currently spending a lot of space in the result file in non-native mode by writing the native frame id, which is always 0. To improve the situation, specialize the native allocation record so the regular one doesn't need to have this field. Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
We are currently wasting a lot of space by writing enumerations as full blown integers, where we could force them to have only 1 byte as we are not using values bigger than 255. Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )