Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies and runtime version #7

Merged
merged 1 commit into from
May 24, 2023

Conversation

justinwride
Copy link
Contributor

ℹ️ About

Updated dependencies and changed runtime version from Node 12 to Node 16.

@kevinpainchaud
Copy link
Contributor

Nice, thanks!

@joltcoke
Copy link

joltcoke commented Jan 3, 2023

@justinwride Thank you! 👏
@JoshCoady Any chance to get this merged?

@jeffsays
Copy link

bump

@JoshCoady JoshCoady merged commit ef9844c into LoveToKnow:master May 24, 2023
@JoshCoady
Copy link
Contributor

Merged
sorry it took so long 🙂

@kevinpainchaud
Copy link
Contributor

Thanks! Can you publish a new release now? :)

@bachiri
Copy link
Contributor

bachiri commented Aug 29, 2023

Hi 👋 @JoshCoady where the version 1.0.1 deployed?

I got this error when trying to get the 1.0.1 version
Error: Unable to resolve action LoveToKnow/slackify-markdown-action@v1.0.1, unable to find version v1.0.1

Thanks

@JoshCoady
Copy link
Contributor

Looks like the deploy is broken due to something in an included gh action. I dont currently have time to track this down, but if someone could post a fix, I'll merge it

Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: /home/runner/work/_actions/cycjimmy/semantic-release-action/v2/node_modules/semantic-release/index.js
require() of ES modules is not supported.
require() of /home/runner/work/_actions/cycjimmy/semantic-release-action/v2/node_modules/semantic-release/index.js from /home/runner/work/_actions/cycjimmy/semantic-release-action/v2/src/index.js is an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which defines all .js files in that package scope as ES modules.
Instead rename /home/runner/work/_actions/cycjimmy/semantic-release-action/v2/node_modules/semantic-release/index.js to end in .cjs, change the requiring code to use import(), or remove "type": "module" from /home/runner/work/_actions/cycjimmy/semantic-release-action/v2/node_modules/semantic-release/package.json.

@bachiri
Copy link
Contributor

bachiri commented Aug 30, 2023

@JoshCoady Just pushed a PR to fix the issue according to

@github-actions
Copy link

🎉 This PR is included in version 1.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants