Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contents): Multiple video authors #83

Merged
merged 1 commit into from
Jun 27, 2022
Merged

feat(contents): Multiple video authors #83

merged 1 commit into from
Jun 27, 2022

Conversation

DanielKrasny
Copy link
Contributor

Pull Request Template

Description

I've extended my previous PR (#82) to the new parser. YT Music videos can also have multiple authors, so I added the authors key. However, I'm unsure about removing author - I kept it there, returning the first item of authors.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Added authors key with array of all video authors. For legacy reasons, author key is kept returning the first entry. Definitions updated respectively.
@LuanRT LuanRT merged commit ef9a22e into LuanRT:main Jun 27, 2022
@LuanRT LuanRT added the enhancement New feature or request label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants