Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beepvp #309

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Add beepvp #309

merged 2 commits into from
Apr 26, 2022

Conversation

baconrehab
Copy link
Contributor

@baconrehab baconrehab commented Apr 20, 2022

Server IP: beepvp.com

General:

  • The pull request title is descriptive. (ex. Added Lunar Network, not Updated servers.json)
  • The pull request does not contain any unrelated commits. (ex. commits from previous pull requests)

Mapping Additions or Updates:

  • No changes were made to the file's formatting.
  • There are no syntax errors.
  • There is no pre-existing mapping matching my id.
  • My field values match your requirements.
  • You can view our patterns here: servers.schema.json, or take a look below and complete the field checklist:
    • id: a lowercase string (ex. myserver)
    • name: a string (ex. MyServerPvP)
    • addresses: an array with lowercase strings (ex. of address my.server)
      • You do not need to specify sub-domains, Lunar Client services automatically detect them.

Logo Additions or Updates:

  • My image is a png file.
  • I uploaded my image to the logos directory.
  • My image has a transparent background and is square (1:1 aspect ratio).
  • My image is 512 pixels in width and height.
  • My image's file name matches its mapping id.

Server IP: beepvp.com
@baconrehab
Copy link
Contributor Author

I have attached my logo below. I do not have permission to upload it to the logos directory.

beepvp

Copy link
Contributor

@GrowlyX GrowlyX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add your server's logo to the logos directory on your own fork.

@baconrehab
Copy link
Contributor Author

@GrowlyX Ok, sorry about that. I fixed it.

@GrowlyX
Copy link
Contributor

GrowlyX commented Apr 23, 2022

@GrowlyX Ok, sorry about that. I fixed it.

You didn't upload it to the correct branch. This PR is matching branch patch-1 on your fork, you uploaded the logo to master.

@baconrehab
Copy link
Contributor Author

@GrowlyX Please excuse my previous mistakes. I believe that I have now uploaded it correctly.

@GrowlyX
Copy link
Contributor

GrowlyX commented Apr 26, 2022

@GrowlyX Please excuse my previous mistakes. I believe that I have now uploaded it correctly.

That's alright. Thanks!

@GrowlyX GrowlyX merged commit a43c860 into LunarClient:master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants