Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Exec.php #1153

Merged
merged 9 commits into from
Sep 6, 2022
Merged

Conversation

corrilan
Copy link
Contributor

Update to allow multiple paths to be specified during import from server, separated by comma.

Update to allow multiple paths to be specified during import from server, separated by comma.
@sonarcloud
Copy link

sonarcloud bot commented Nov 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ildyria
Copy link
Member

ildyria commented Nov 26, 2021

Seems like you managed to get a Pull Request going. If you have any feedback with regard to https://lycheeorg.github.io/docs/contributions.html#illustrated-example please do tell so we can improve.

Copy link
Collaborator

@nagmat84 nagmat84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that the client (CLI or web front-end) already passes a correct array of paths to be imported and not a single string separated by semicolons. There might be cases where the semicolon is part of a path and thus must not be used as separator.

app/Actions/Import/Exec.php Outdated Show resolved Hide resolved
app/Actions/Import/Exec.php Outdated Show resolved Hide resolved
@ildyria
Copy link
Member

ildyria commented Jul 27, 2022

I did a path on that with associated PR: LycheeOrg/Lychee-front#308

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #1153 (16f4897) into master (e18c16b) will decrease coverage by 0.97%.
The diff coverage is 100.00%.

app/Locale/German.php Outdated Show resolved Hide resolved
app/Actions/Import/FromServer.php Show resolved Hide resolved
Copy link
Collaborator

@nagmat84 nagmat84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, but looks sane.

Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
@ildyria
Copy link
Member

ildyria commented Jul 27, 2022

I have not tested it either. 😇

@nagmat84
Copy link
Collaborator

@ildyria Before hitting the "apply" button the next time, read the comment below the suggestion ;-) #1153 (comment) The first suggestion contained a spelling error.

@ildyria
Copy link
Member

ildyria commented Aug 6, 2022

Need to merge Lychee-front (waiting for other PR before) and then we can merge this.

@ildyria ildyria merged commit f2bf7c8 into LycheeOrg:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants