Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New locale strings #1377

Merged
merged 4 commits into from
Jun 26, 2022
Merged

New locale strings #1377

merged 4 commits into from
Jun 26, 2022

Conversation

kamil4
Copy link
Contributor

@kamil4 kamil4 commented Jun 24, 2022

Server side of LycheeOrg/Lychee-front#303: just some locale strings.

@codecov
Copy link

codecov bot commented Jun 24, 2022 •
edited
Loading

Codecov Report

Merging #1377 (97a72f7) into master (8d1cf2f) will decrease coverage by 0.88%.
The diff coverage is n/a.

qwerty287
qwerty287 approved these changes Jun 25, 2022
View reviewed changes
app/Locale/German.php Outdated Show resolved Hide resolved
nagmat84
nagmat84 approved these changes Jun 25, 2022
View reviewed changes
Copy link
Collaborator

@nagmat84 nagmat84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I haven't tested it, but I assume you did. Moreover, I only had a quick glance on it, but I actually don't care for proper and nice messages right now. I have too much other stuff on my pile of work.

kamil4 and others added 3 commits June 25, 2022 22:40
@kamil4 @qwerty287
Update app/Locale/German.php
8b20732 
Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
@kamil4
Sync the frontend
e87bf99
@kamil4
Fix the permissions
97a72f7
@kamil4 kamil4 merged commit 7c8fa64 into master Jun 26, 2022
@kamil4 kamil4 deleted the fix-tag-albums branch June 26, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagmat84 nagmat84 nagmat84 approved these changes

@qwerty287 qwerty287 qwerty287 approved these changes

@ildyria ildyria Awaiting requested review from ildyria

@d7415 d7415 Awaiting requested review from d7415

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamil4 @nagmat84 @qwerty287