Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove $locale in favor of Lang::get() #1490

Merged
merged 2 commits into from
Sep 4, 2022
Merged

remove $locale in favor of Lang::get() #1490

merged 2 commits into from
Sep 4, 2022

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Aug 27, 2022

Make use of the Lang facade instead of $locale.

@codecov
Copy link

codecov bot commented Aug 27, 2022 •
edited
Loading

Codecov Report

Merging #1490 (5f6f5de) into master (bb98373) will decrease coverage by 0.90%.
The diff coverage is n/a.

@ildyria ildyria added this to the 4.6.1 milestone Aug 27, 2022
@ildyria ildyria requested a review from a team August 27, 2022 09:08
qwerty287
qwerty287 suggested changes Aug 27, 2022
View reviewed changes
Copy link
Contributor

@qwerty287 qwerty287 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The frontend submodule uses your laravel 9 port branch.

@ildyria
Copy link
Member Author

ildyria commented Aug 27, 2022

The frontend submodule uses your laravel 9 port branch.

oupsie. :')

@ildyria ildyria requested a review from qwerty287 August 27, 2022 09:19
@qwerty287 qwerty287 merged commit e80bf8c into master Sep 4, 2022
@qwerty287 qwerty287 mentioned this pull request Sep 4, 2022
Merged
@ildyria ildyria deleted the view-refactoring branch September 6, 2022 08:51
@qwerty287 qwerty287 modified the milestones: 4.6.1, 4.6.0 Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagmat84 nagmat84 nagmat84 approved these changes

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ildyria @nagmat84 @qwerty287