Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add exec check #1540

Merged
merged 2 commits into from
Oct 4, 2022
Merged

add exec check #1540

merged 2 commits into from
Oct 4, 2022

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Sep 29, 2022

Add missing safety check on exec.

@ildyria ildyria requested review from nagmat84 and a team September 29, 2022 21:34
@ildyria ildyria added this to the 4.6.2 milestone Sep 29, 2022
@codecov
Copy link

codecov bot commented Sep 29, 2022 •
edited
Loading

Codecov Report

Merging #1540 (8bd5599) into master (52ea5b8) will decrease coverage by 0.75%.
The diff coverage is 52.94%.

Additional details and impacted files

@ildyria ildyria mentioned this pull request Sep 29, 2022
Merged
nagmat84
nagmat84 requested changes Oct 2, 2022
View reviewed changes
app/Models/Extensions/ConfigsHas.php Outdated Show resolved Hide resolved
nagmat84
nagmat84 approved these changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@nagmat84 nagmat84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested but LGTM.

@ildyria ildyria merged commit 80fc69d into master Oct 4, 2022
@ildyria ildyria deleted the fix-exe branch October 4, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamil4 kamil4 kamil4 left review comments

@nagmat84 nagmat84 nagmat84 approved these changes

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ildyria @nagmat84 @kamil4 @qwerty287