Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2fa tests #1698

Merged
merged 6 commits into from
Jan 8, 2023
Merged

Fix 2fa tests #1698

merged 6 commits into from
Jan 8, 2023

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 8, 2023

This will make sure that 2FA is properly executed.
Values have been generated locally from a yubikey 4.

@ildyria
Copy link
Member Author

ildyria commented Jan 8, 2023

Will need to fix it a bit more :')

@ildyria
Copy link
Member Author

ildyria commented Jan 8, 2023

Now all tests should pass. :)

@codecov
Copy link

codecov bot commented Jan 8, 2023 •
edited
Loading

Codecov Report

Merging #1698 (cde31c5) into master (ecef28a) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files

@ildyria ildyria merged commit bb6cc86 into master Jan 8, 2023
@ildyria ildyria deleted the beter-2fa-tests branch January 8, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @qwerty287