Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stacked 7] Add standalone flow. #2371

Merged
merged 1 commit into from
Apr 11, 2024
Merged

[stacked 7] Add standalone flow. #2371

merged 1 commit into from
Apr 11, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Apr 10, 2024

Stand alone flow (when there are no live variant already existing).

@ildyria ildyria changed the title Add standalone flow. [stacked 7] Add standalone flow. Apr 10, 2024
@ildyria ildyria marked this pull request as ready for review April 10, 2024 15:53
@ildyria ildyria added the Review: medium Medium review expected: not many files, some attention to details required. label Apr 10, 2024
Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things, nothing major.

app/Actions/Photo/Pipes/Standalone/CreateSizeVariants.php Outdated Show resolved Hide resolved
app/Actions/Photo/Pipes/Standalone/FetchSourceImage.php Outdated Show resolved Hide resolved
app/Actions/Photo/Pipes/Standalone/FetchSourceImage.php Outdated Show resolved Hide resolved
app/Actions/Photo/Pipes/Standalone/PlacePhoto.php Outdated Show resolved Hide resolved
app/Contracts/PhotoCreate/StandalonePipe.php Outdated Show resolved Hide resolved
@ildyria ildyria force-pushed the use-pipes-duplicate-flow branch 3 times, most recently from 759c305 to a26298e Compare April 11, 2024 11:20
Base automatically changed from use-pipes-duplicate-flow to master April 11, 2024 11:44
@ildyria ildyria merged commit 069e735 into master Apr 11, 2024
31 checks passed
@ildyria ildyria deleted the use-pipes-singleflow branch April 11, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: medium Medium review expected: not many files, some attention to details required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants