Skip to content

Commit

Permalink
[FIX] hr_recruitment: email from in template should be safe
Browse files Browse the repository at this point in the history
Create a hr.attendant in a stage where a mail template is present.
Fill the email field as: Name Surname <name@surname.com>

Before this commit:
- the created partner's email has been rendered as name@surname.com&gt;
- the email failed to be sended because of this

This was because Jinja rendered that snippet escaping the special characters
Putting a 'pipe' safe in the snippet does the trick

After this commit:
both the partner and the email are created successfuly

OPW 1830739
closes odoo#24059
  • Loading branch information
kebeclibre committed Apr 5, 2018
1 parent 0fc2ee8 commit e05b2d0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions addons/hr_recruitment/data/hr_recruitment_data.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<record id="email_template_data_applicant_refuse" model="mail.template">
<field name="name">Applicant: Refuse</field>
<field name="subject">Application refused</field>
<field name="email_to">${object.email_from}</field>
<field name="email_to">${object.email_from | safe}</field>
<field name="partner_to">${object.partner_id and object.partner_id.id or ''}</field>
<field name="lang">${object.partner_id and object.partner_id.lang or ''}</field>
<field name="model_id" ref="hr_recruitment.model_hr_applicant"/>
Expand All @@ -37,7 +37,7 @@ Unfortunately, your profile does not match with our needs</p>
<record id="email_template_data_applicant_interest" model="mail.template">
<field name="name">Applicant: Interest</field>
<field name="subject">Application approved</field>
<field name="email_to">${object.email_from}</field>
<field name="email_to">${object.email_from | safe}</field>
<field name="partner_to">${object.partner_id and object.partner_id.id or ''}</field>
<field name="lang">${object.partner_id and object.partner_id.lang or ''}</field>
<field name="model_id" ref="hr_recruitment.model_hr_applicant"/>
Expand Down

0 comments on commit e05b2d0

Please sign in to comment.