fix some dark mode controls

[rounk-ctrl]

some of the dark mode controls look really bad
buttons, combobox, edit

smooth listview
no more black artifacts

statusbar
no more artifacts

toolbar (for classic)
no more artifacts

[MouriNaruto]

The changes you need also be done on NanaZip.UI.Modern which is the modern flavor of NanaZip.

Kenji Mouri

[MouriNaruto]

Have you tested switching light and dark mode at runtime?

Kenji Mouri

[rounk-ctrl]

wait my bad i didnt add to modern

and theres a lot of issues with this implementation

[rounk-ctrl]

Have you tested switching light and dark mode at runtime?

Kenji Mouri

yep works

[MouriNaruto]

OK. I also have a suggestion.

Maybe you can move listview, toolbar, and statusbar workaround into "NanaZip.Frieren/NanaZip.Frieren.DarkMode.cpp".

Because it can apply to all GUI components which uses the legacy UI controls.

Also can simplify the implementation.

Kenji Mouri

[rounk-ctrl]

done

[MouriNaruto]

Maybe NanaZip.UI.*'s changes can also be moved to NanaZip.Frieren if OK to simplify the implementation. (For example, LVS_EX_DOUBLEBUFFER and WS_EX_COMPOSITED.)

I want to know something about Refresh_StatusBar's workaround.

In general, your current implementation is almost OK.

Kenji Mouri

[rounk-ctrl]

i tried moving LVS_EX_DOUBLEBUFFERED to Frieren but it didn't work. I don't know why. It only seems to work if i put it there

For the toolbar, I did move it to Frieren, i forgor to remove it from that file

For the statusbar, there was some bug where resizing the window would cause the statusbar text to behave weirdly. So i'm just making it redraw itself while resizing.

[MouriNaruto]

@rounk-ctrl

MileAllowDarkModeForApp should continue to be used because I had done the shim for better compatibility.

https://github.com/ProjectMile/Mile.Windows.Helpers/blob/836371d67b512ca93b56ba8ec5b052f8320bb597/Mile.Helpers/Mile.Helpers.cpp#L245

Kenji Mouri

[rounk-ctrl]

oh i see, i thought it just called AllowDarkModeForApp. my bad

[MouriNaruto]

@rounk-ctrl NanaZip has introduced several wrappers for simplifying the old Windows version compatibility implementation.

Also, I have fixed the tab control theming issue when using the dark and light mode switch dynamically after merging your PR.

be1dec7

Kenji Mouri

[rounk-ctrl]

@MouriNaruto btw do not use WS_EX_COMPOSITED with listview. It breaks it

[MouriNaruto]

Got it.

Kenji Mouri

[eggbean]

The Up button is still unfixed. I would prefer to turn off dark mode altogether.