Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment form #25

Merged
merged 12 commits into from
Apr 30, 2023
Merged

Comment form #25

merged 12 commits into from
Apr 30, 2023

Conversation

dbajollari1
Copy link
Collaborator

No description provided.

@MAPReiff
Copy link
Owner

@dbajollari1 functionality looks good but 2 issues I noticed.

The timestamps do not render properly. The top one should be 20 Apr 2023 19:01:50, the middle one should be 29 Apr 2023 19:02:00, etc.
image

The comment form does not clear its contents after you click submit, so the data is still in there if you go to leave another comment.

@MAPReiff MAPReiff added enhancement New feature or request data Changes to the data directory files routes Changes to the routes directory files tickets Changes to tickets pages Changes to pages (HTML, CSS, Handlebars, etc) labels Apr 29, 2023
Copy link
Owner

@MAPReiff MAPReiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MAPReiff MAPReiff merged commit f67adea into main Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Changes to the data directory files enhancement New feature or request pages Changes to pages (HTML, CSS, Handlebars, etc) routes Changes to the routes directory files tickets Changes to tickets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants