Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit ticket page #32

Merged
merged 28 commits into from
May 5, 2023
Merged

Edit ticket page #32

merged 28 commits into from
May 5, 2023

Conversation

Val-Bustamante
Copy link
Collaborator

Fixed edit ticket page so that the fields are automatically filled with the values of the original ticket. Added way for users to add owners. Made deadline be of type date time when inserted into mongo.

@MAPReiff
Copy link
Owner

MAPReiff commented May 5, 2023

@Val-Bustamante this branch breaks the seed file:
image

@MAPReiff
Copy link
Owner

MAPReiff commented May 5, 2023

@Val-Bustamante
Editing a ticket does not pull all of the data in, only the first word of the title/description

image

image

@MAPReiff
Copy link
Owner

MAPReiff commented May 5, 2023

@Val-Bustamante
User Marcus Smith does not show up as an owner in the owners selection to make or edit a ticket. Prob need to iterate 1 more time on whatever list/array you are using for the users.

Copy link
Owner

@MAPReiff MAPReiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good!

@MAPReiff
Copy link
Owner

MAPReiff commented May 5, 2023

Github says the PR can be merged without issue, but doing a rebase with main seems to have a lot of conflicts. @Val-Bustamante @bigguyhere @dbajollari1 lets try to review the conflicts together today before I break something trying to do it myself.

@MAPReiff
Copy link
Owner

MAPReiff commented May 5, 2023

Found another issue on the PR. When editing a ticket and adding an owner, it does not update that owner’s list of owned tickets This also applies to unassigning an owner not removing the ticket from their list.

Not sure if this is for @Val-Bustamante for the page/routes/changes to the data function or for @dbajollari1 for the data functions originally.

@MAPReiff MAPReiff added enhancement New feature or request data Changes to the data directory files routes Changes to the routes directory files tickets Changes to tickets labels May 5, 2023
@MAPReiff MAPReiff added the pages Changes to pages (HTML, CSS, Handlebars, etc) label May 5, 2023
@MAPReiff MAPReiff self-requested a review May 5, 2023 17:15
@bigguyhere bigguyhere self-requested a review May 5, 2023 17:29
Copy link
Collaborator

@bigguyhere bigguyhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed issues with last review myself

@MAPReiff
Copy link
Owner

MAPReiff commented May 5, 2023

users can not make themselves owners of their own tickets when making a new ticket (which could be a real world use case), but admins can.
This works fine on editing a ticket.

Ignore this is propper behavior

Copy link
Owner

@MAPReiff MAPReiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we're good now!

@MAPReiff MAPReiff merged commit ecba31e into main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Changes to the data directory files enhancement New feature or request pages Changes to pages (HTML, CSS, Handlebars, etc) routes Changes to the routes directory files tickets Changes to tickets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants