fix ticket issue with owners #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w that the buttons are gone
…w that the buttons are gone
Not html related but found it while testing this branch
Can not use <p> inside of <span> A date input can not have a placeholder value
Previous code did not do anything at all as the form had no ID. Previous code once the ID was added still did not do anything as it did not wait for the page to load. Previous code once updated to wait was busted as it did not actually check for important stuff such as if values were blank, some non required values failed as the js thought they were required, and multiple instances of undefined vars being called.
The check for deadline was completed busted as well. Regex wasnt checking the right form of date I dont even know how the day/month.year substrings were being extracted but it clearly did not do anything so had to be fixed tried to compare with the created on data which is not even passed in.. Scroll to top of page when error so they can see it
Tota11y fixes
HTML & JS fixes
|
Rebased with main, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.