-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic middleware, registering users #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entering / route without an account will send you to login Logging in will send you to /
MAPReiff
added
enhancement
New feature or request
data
Changes to the data directory files
routes
Changes to the routes directory files
users
Changes to users
pages
Changes to pages (HTML, CSS, Handlebars, etc)
labels
Apr 22, 2023
bigguyhere
approved these changes
Apr 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could move middleware to a separate file, but otherwise looks really good !
try { | ||
checkEmail(emailAddress); | ||
checkPassword(password); | ||
form.submit(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could move preventDefault to catch to remove the need for this line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
data
Changes to the data directory files
enhancement
New feature or request
pages
Changes to pages (HTML, CSS, Handlebars, etc)
routes
Changes to the routes directory files
users
Changes to users
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic middleware for main page, login, and register.
Register new users:
Login page client-side error checking js