Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic middleware, registering users #9

Merged
merged 9 commits into from
Apr 22, 2023
Merged

Basic middleware, registering users #9

merged 9 commits into from
Apr 22, 2023

Conversation

MAPReiff
Copy link
Owner

Basic middleware for main page, login, and register.
Register new users:

  • Page with form
  • Client-side error checking js
  • Routes with error checking
  • Updated create user in data to account for input changes
    Login page client-side error checking js

@MAPReiff MAPReiff added enhancement New feature or request data Changes to the data directory files routes Changes to the routes directory files users Changes to users pages Changes to pages (HTML, CSS, Handlebars, etc) labels Apr 22, 2023
Copy link
Collaborator

@bigguyhere bigguyhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could move middleware to a separate file, but otherwise looks really good !

try {
checkEmail(emailAddress);
checkPassword(password);
form.submit();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could move preventDefault to catch to remove the need for this line

@bigguyhere bigguyhere merged commit f070a47 into main Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Changes to the data directory files enhancement New feature or request pages Changes to pages (HTML, CSS, Handlebars, etc) routes Changes to the routes directory files users Changes to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants