Skip to content

Commit

Permalink
node: rename startNetworking to openEndpoints (ethereum#22105)
Browse files Browse the repository at this point in the history
  • Loading branch information
renaynay committed Jan 4, 2021
1 parent 47820ef commit 5c2a7ce
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions node/node.go
Original file line number Diff line number Diff line change
Expand Up @@ -159,12 +159,13 @@ func (n *Node) Start() error {
return ErrNodeStopped
}
n.state = runningState
err := n.startNetworking()
// open networking and RPC endpoints
err := n.openEndpoints()
lifecycles := make([]Lifecycle, len(n.lifecycles))
copy(lifecycles, n.lifecycles)
n.lock.Unlock()

// Check if networking startup failed.
// Check if endpoint startup failed.
if err != nil {
n.doClose(nil)
return err
Expand Down Expand Up @@ -247,12 +248,14 @@ func (n *Node) doClose(errs []error) error {
}
}

// startNetworking starts all network endpoints.
func (n *Node) startNetworking() error {
// openEndpoints starts all network and RPC endpoints.
func (n *Node) openEndpoints() error {
// start networking endpoints
n.log.Info("Starting peer-to-peer node", "instance", n.server.Name)
if err := n.server.Start(); err != nil {
return convertFileLockError(err)
}
// start RPC endpoints
err := n.startRPC()
if err != nil {
n.stopRPC()
Expand Down

0 comments on commit 5c2a7ce

Please sign in to comment.