Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plateau model bridge #168

Merged
merged 6 commits into from
Jan 10, 2024
Merged

Plateau model bridge #168

merged 6 commits into from
Jan 10, 2024

Conversation

xinmiaooo
Copy link
Member

橋梁モデルの属性読み込みとテスト

#167 を含めています

relate #165

@xinmiaooo xinmiaooo requested a review from a team January 10, 2024 09:42
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Files Patch % Lines
nusamai-plateau/src/models/bridge.rs 36.84% 12 Missing ⚠️
nusamai-plateau/src/models/iur/uro/bridge.rs 36.36% 7 Missing ⚠️
nusamai-citygml/src/parser.rs 50.00% 3 Missing ⚠️
Additional details and impacted files
Components Coverage Δ
GUI ∅ <ø> (∅)
Backend 75.74% <ø> (-0.37%) ⬇️
Libraries 86.20% <38.88%> (-0.12%) ⬇️

📢 Thoughts on this report? Let us know!

ciscorn
ciscorn approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@ciscorn ciscorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@ciscorn ciscorn merged commit 720e90c into main Jan 10, 2024
3 of 4 checks passed
@ciscorn ciscorn deleted the plateau-model-bridge branch January 10, 2024 10:35
@ciscorn ciscorn mentioned this pull request Jan 10, 2024
Closed
@ciscorn ciscorn added the CityGML Models PLATEAU CityGML models label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciscorn ciscorn ciscorn approved these changes

Assignees

@xinmiaooo xinmiaooo

Labels
CityGML Models PLATEAU CityGML models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xinmiaooo @ciscorn