gpkg: bbox管理のちょっとした改善 #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciscorn
commented
Feb 20, 2024
Comment on lines
-219
to
-224
| tree_flattening: transformer::TreeFlatteningSpec::Flatten { | ||
| // TODO: set properly after the flattening transformer is implemented | ||
| feature: transformer::FeatureFlatteningOption::None, | ||
| data: transformer::DataFlatteningOption::None, | ||
| object: transformer::ObjectFlatteningOption::None, | ||
| }, |
There was a problem hiding this comment.
TreeFlatteningはいま壊れているようなので、gpkg sinkが動くように TreeFlatteningSpec::None にしておきます。
ciscorn
commented
Feb 20, 2024
Comment on lines
+197
to
199
| for (table_name, bbox) in table_bboxes { | ||
| tx.update_bbox(&table_name, bbox.to_tuple()).await.unwrap(); | ||
| } |
ciscorn
commented
Feb 20, 2024
| @@ -195,13 +191,11 @@ impl GpkgSink { | |||
| .await | |||
| .unwrap(); | |||
|
|
|||
| table_bboxes.get_mut(&table_name).unwrap().merge(&bbox); | |||
| table_bboxes.entry(table_name).or_default().merge(&bbox); | |||
There was a problem hiding this comment.
必要になったテーブルのbboxだけ用意するように
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files
📢 Thoughts on this report? Let us know! |
nokonoko1203
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
登場したテーブルのみのbboxを管理して、gpkg_contentsを更新するようにします。（ちょっとした変更なので他の作業とは特段コンプリクトしないと思います）。
（その他、いまの main に unused imports が色々と混入しているので、除去します）