Remove trunk params #10

grace-omotoso · 2021-03-02T19:42:51Z

Resolves #2

prigoyal

looks really great :) left some inline comments and good to go after those are addressed!

@uhbuhb I think it will be good time to upstream MLH to main vissl master as any configs that land in main master will then be able to land with the new structural change done in this PR :)

vissl/trainer/train_zero_task.py

tools/cluster_features_and_label.py

docs/source/vissl_modules/models.rst

docs/source/conf.py

.circleci/config.yml

uhbuhb · 2021-03-03T07:46:03Z

looks really great :) left some inline comments and good to go after those are addressed!

@uhbuhb I think it will be good time to upstream MLH to main vissl master as any configs that land in main master will then be able to land with the new structural change done in this PR :)

do you mean before this PR is merged or after? Ill open a PR for now...

prigoyal · 2021-03-03T12:37:06Z

@

looks really great :) left some inline comments and good to go after those are addressed!
@uhbuhb I think it will be good time to upstream MLH to main vissl master as any configs that land in main master will then be able to land with the new structural change done in this PR :)

do you mean before this PR is merged or after? Ill open a PR for now...

@uhbuhb , sorry about vague comment earlier. I think once this PR lands we can upstream this individual PR to main VISSL master. Then we can ensure that any new config files (yaml files) that come in VISSL are aligned with the PR changes.

.circleci/config.yml

.pre-commit-config.yaml

Some TRUNK_PARAMS were re-introduced during the rebase

akainth015

LGTM, aside from docs/source/conf.py I did not see any formatting changes.

docs/source/conf.py

prigoyal

AWESOME work!!! thank you @grace-omotoso and @akainth015 :)

Summary: Pull Request resolved: fairinternal/ssl_scaling#79 This is a coagulate merge, coordinated by prigoyal and uhbuhb. It addresses the following issues/pull requests: 1. MLH-Fellowship#7 2. MLH-Fellowship#8 3. MLH-Fellowship#9 4. MLH-Fellowship#10 5. MLH-Fellowship#13 6. MLH-Fellowship#14 Pull Request resolved: facebookresearch#221 Differential Revision: D27608671 Pulled By: prigoyal fbshipit-source-id: d15232bb00d11db7b2c245a9312d3d5be165ada3 Co-authored-by: grace-omotoso

Summary: Pull Request resolved: fairinternal/ssl_scaling#79 This is a coagulate merge, coordinated by prigoyal and uhbuhb. It addresses the following issues/pull requests: 1. MLH-Fellowship#7 2. MLH-Fellowship#8 3. MLH-Fellowship#9 4. MLH-Fellowship#10 5. MLH-Fellowship#13 6. MLH-Fellowship#14 Pull Request resolved: facebookresearch#221 Differential Revision: D27608671 Pulled By: prigoyal fbshipit-source-id: ebe71ff5b25fa77394661d442062fdb127cc9a48 Co-authored-by: grace-omotoso

Summary: Pull Request resolved: facebookresearch#294 Pull Request resolved: fairinternal/ssl_scaling#79 This is a coagulate merge, coordinated by prigoyal and uhbuhb. It addresses the following issues/pull requests: 1. MLH-Fellowship#7 2. MLH-Fellowship#8 3. MLH-Fellowship#9 4. MLH-Fellowship#10 5. MLH-Fellowship#13 6. MLH-Fellowship#14 Pull Request resolved: facebookresearch#221 Differential Revision: D27608671 Pulled By: prigoyal fbshipit-source-id: 64920e6d09e95a783673641024b80f2acb7b3966 Co-authored-by: grace-omotoso

Summary: This is a coagulate merge, coordinated by prigoyal and uhbuhb. It addresses the following issues/pull requests: 1. MLH-Fellowship#7 2. MLH-Fellowship#8 3. MLH-Fellowship#9 4. MLH-Fellowship#10 5. MLH-Fellowship#13 6. MLH-Fellowship#14 Pull Request resolved: facebookresearch#221 Differential Revision: D27794128 Pulled By: prigoyal fbshipit-source-id: 5c44a91c2e8be72fa35f787084be6048ed4aa349 Co-authored-by: grace-omotoso

Summary: Pull Request resolved: facebookresearch#295 This is a coagulate merge, coordinated by prigoyal and uhbuhb. It addresses the following issues/pull requests: 1. MLH-Fellowship#7 2. MLH-Fellowship#8 3. MLH-Fellowship#9 4. MLH-Fellowship#10 5. MLH-Fellowship#13 6. MLH-Fellowship#14 Pull Request resolved: facebookresearch#221 Differential Revision: D27794128 Pulled By: prigoyal fbshipit-source-id: 4fa0322a902e446a02b46a2233eb54c6fac92f8f Co-authored-by: grace-omotoso

Summary: Pull Request resolved: facebookresearch#295 This is a coagulate merge, coordinated by prigoyal and uhbuhb. It addresses the following issues/pull requests: 1. MLH-Fellowship#7 2. MLH-Fellowship#8 3. MLH-Fellowship#9 4. MLH-Fellowship#10 5. MLH-Fellowship#13 6. MLH-Fellowship#14 Pull Request resolved: facebookresearch#221 Differential Revision: D27794128 Pulled By: prigoyal fbshipit-source-id: 00300039ef55ddcd59672d56e068269d5db010a4 Co-authored-by: grace-omotoso

Summary: Pull Request resolved: facebookresearch#295 This is a coagulate merge, coordinated by prigoyal and uhbuhb. It addresses the following issues/pull requests: 1. MLH-Fellowship#7 2. MLH-Fellowship#8 3. MLH-Fellowship#9 4. MLH-Fellowship#10 5. MLH-Fellowship#13 6. MLH-Fellowship#14 Pull Request resolved: facebookresearch#221 Differential Revision: D27794128 Pulled By: prigoyal fbshipit-source-id: 6e772f0dfcf8d39f613404be91b98f445f404ec1 Co-authored-by: grace-omotoso

Summary: Pull Request resolved: facebookresearch#295 This is a coagulate merge, coordinated by prigoyal and uhbuhb. It addresses the following issues/pull requests: 1. MLH-Fellowship#7 2. MLH-Fellowship#8 3. MLH-Fellowship#9 4. MLH-Fellowship#10 5. MLH-Fellowship#13 6. MLH-Fellowship#14 Pull Request resolved: facebookresearch#221 Differential Revision: D27794128 Pulled By: prigoyal fbshipit-source-id: 92903d11a64e7540ede12d027cbbc23cb201adef Co-authored-by: grace-omotoso

Summary: Pull Request resolved: facebookresearch#295 This is a coagulate merge, coordinated by prigoyal and uhbuhb. It addresses the following issues/pull requests: 1. MLH-Fellowship#7 2. MLH-Fellowship#8 3. MLH-Fellowship#9 4. MLH-Fellowship#10 5. MLH-Fellowship#13 6. MLH-Fellowship#14 Pull Request resolved: facebookresearch#221 Reviewed By: iseessel Differential Revision: D27794128 Pulled By: prigoyal fbshipit-source-id: ef1e0e3403b5a89e4aace01bdb0ba1bf04d7cc96 Co-authored-by: grace-omotoso

Summary: Pull Request resolved: facebookresearch#295 This is a coagulate merge, coordinated by prigoyal and uhbuhb. It addresses the following issues/pull requests: 1. MLH-Fellowship#7 2. MLH-Fellowship#8 3. MLH-Fellowship#9 4. MLH-Fellowship#10 5. MLH-Fellowship#13 6. MLH-Fellowship#14 Pull Request resolved: facebookresearch#221 Reviewed By: iseessel Differential Revision: D27794128 Pulled By: prigoyal fbshipit-source-id: 3320c1e37f762770faba9afc0749a18013074401 Co-authored-by: grace-omotoso

Summary: Pull Request resolved: #295 This is a coagulate merge, coordinated by prigoyal and uhbuhb. It addresses the following issues/pull requests: 1. MLH-Fellowship#7 2. MLH-Fellowship#8 3. MLH-Fellowship#9 4. MLH-Fellowship#10 5. MLH-Fellowship#13 6. MLH-Fellowship#14 Pull Request resolved: #221 Reviewed By: iseessel Differential Revision: D27794128 Pulled By: prigoyal fbshipit-source-id: 3f78b54ccc9fe529aab3899423b73cd1547bf029 Co-authored-by: grace-omotoso

prigoyal requested changes Mar 2, 2021

View reviewed changes

uhbuhb force-pushed the master branch from 51be11f to 8c468c6 Compare March 3, 2021 07:50

grace-omotoso force-pushed the remove_trunk_params branch from 15144ab to a40e8e1 Compare March 3, 2021 18:46

uhbuhb force-pushed the remove_trunk_params branch 3 times, most recently from 3fa97a7 to 3b3842a Compare March 3, 2021 18:55

uhbuhb force-pushed the master branch from 8c468c6 to 88dd0e5 Compare March 3, 2021 19:04

grace-omotoso force-pushed the master branch from 88dd0e5 to d0cf82b Compare March 4, 2021 18:06

grace-omotoso force-pushed the remove_trunk_params branch from 47eb6d2 to 7d69cc5 Compare March 4, 2021 18:17

akainth015 force-pushed the master branch 2 times, most recently from b6df1c8 to 453c0e9 Compare March 9, 2021 15:22

akainth015 force-pushed the master branch from 453c0e9 to f10a005 Compare March 15, 2021 15:37

prigoyal requested changes Mar 16, 2021

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

.pre-commit-config.yaml Outdated Show resolved Hide resolved

grace-omotoso force-pushed the master branch from f10a005 to 81ac60d Compare March 16, 2021 17:17

grace-omotoso force-pushed the remove_trunk_params branch from 7d69cc5 to 2aee210 Compare March 16, 2021 17:31

grace-omotoso added 13 commits March 16, 2021 12:32

removed trunk params from file

3858f7c

removed trunk params from file

ae31229

removed trunk params from file

211a648

removed trunk params from config files in models

e939d70

removed trunk_params from files

cdf81f3

removed TRUNK_PARAMS from imaener1k/models

cb16a4d

removed TRUNK_PARAMS from file

40cc446

removed TRUNK_PARAMS from imagenet1k/other_styles config files

c6d3ca1

removed TRUNK_PARAMS from inaturalist18/models config files

ce4afc7

removed TRUNK_PARAMS from file

e2a1848

removed TRUNK_PARAMS from openimages config files

8ccc63b

removed TRUNK_PARAMS from places205 config files

a6d6ca3

removed TRUNKS_PARAMS from voc07 config files

c962e19

grace-omotoso added 2 commits March 16, 2021 12:32

removed TRUNK_PARAMS from all config files

7ade726

removed TRUNK_PARAMS from doc files

277ee62

grace-omotoso force-pushed the remove_trunk_params branch from 2aee210 to c2bee7f Compare March 16, 2021 17:33

grace-omotoso and others added 5 commits March 16, 2021 12:41

removed trunk_params from trunk files

4f61284

removed trunk_params from tests folder

2e6116e

Finish changes to config files

63ff469

worked on code review feedback

e9af4a7

fixed issues with isort on some files

b76cb94

grace-omotoso force-pushed the remove_trunk_params branch from c2bee7f to b76cb94 Compare March 16, 2021 17:42

Remove TRUNK_PARAMS from defaults.yaml and regnet16Gf.yaml

b720f84

Some TRUNK_PARAMS were re-introduced during the rebase

akainth015 force-pushed the remove_trunk_params branch from 464e52f to b720f84 Compare March 16, 2021 21:32

akainth015 approved these changes Mar 16, 2021

View reviewed changes

docs/source/conf.py Outdated Show resolved Hide resolved

removed unwanted isort changes

64b6d90

prigoyal approved these changes Mar 17, 2021

View reviewed changes

prigoyal merged commit 571644b into master Mar 17, 2021

prigoyal deleted the remove_trunk_params branch March 17, 2021 12:28

akainth015 mentioned this pull request Apr 8, 2021

Major League Hacking Fellowship Merge facebookresearch/vissl#221

Closed

prigoyal mentioned this pull request Apr 15, 2021

Major League Hacking Fellowship Merge (#79) facebookresearch/vissl#294

Closed

prigoyal mentioned this pull request Apr 15, 2021

Major League Hacking Fellowship Merge (#221) facebookresearch/vissl#295

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove trunk params #10

Remove trunk params #10

grace-omotoso commented Mar 2, 2021

prigoyal left a comment

uhbuhb commented Mar 3, 2021

prigoyal commented Mar 3, 2021

akainth015 left a comment

prigoyal left a comment

Remove trunk params #10

Remove trunk params #10

Conversation

grace-omotoso commented Mar 2, 2021

prigoyal left a comment

Choose a reason for hiding this comment

uhbuhb commented Mar 3, 2021

prigoyal commented Mar 3, 2021

akainth015 left a comment

Choose a reason for hiding this comment

prigoyal left a comment

Choose a reason for hiding this comment