Irj_file_validation #236
Merged
Irj_file_validation #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@denismerigoux AFAIK, should add some tests for the new module in the CI, otherwise in itself it seems OK for a first merge. |
|
Following yesterday discussion, let’s merge it ASAP so we can at least use it and not wait months again for a third rewrite, test integration, and so on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short term plan: add a small standalone module for IRJ file validation.
Long term: allow to validate and translate multiple file formats (APIs, IRJ, Alpage…)
For the IRJ validation, I have covered all cases found in 2022 files. For completion sake I would have liked to test for #CONTROLES-RAPPELS part, but it creates a conflict and I do not understand why.
Note: this error handling is deprecated in Menhir.