Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] #231 - User, Log, Task Validator 분리 #232

Merged
merged 10 commits into from
Feb 29, 2024
Merged

[Feat] #231 - User, Log, Task Validator 분리 #232

merged 10 commits into from
Feb 29, 2024

Conversation

0lynny
Copy link
Member

@0lynny 0lynny commented Feb 29, 2024

🚀PullRequest🚀

📟 관련 이슈

💻 작업 내용

  • User, Log, Task Validator 분리하였습니다.
  • index관련한 공통된 Validator는 IndexValidator로 따로 뺴두었습니다.
  • 기존 각 Validator에 있었던 유저관련 Validator는 UserValidator를 사용하도록 변경하였습니다!

📝 리뷰 노트

  • IndexValidator 패키징 위치가 괜찮은지 잘 모르겠네요..
  • 누락된 부분이나 불필요하다고 생각되는 부분 있으면 리뷰 남겨주세요!

@0lynny 0lynny requested a review from its-sky February 29, 2024 11:58
@0lynny 0lynny self-assigned this Feb 29, 2024
Copy link
Member

@its-sky its-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오.. 너무 꼼꼼히 잘하셨네요 ! 수고하셨습니다~


public class LogValidator {

public static void validateLogNum(Long requestNum, Long originNum) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p4;
개인적으로 메소드명을 validateLogNumber로 하는게 좋다고 생각하는데 어떻게 생각하시나요?

@0lynny 0lynny merged commit 43a6391 into develop Feb 29, 2024
1 check passed
@its-sky its-sky deleted the feature/#231 branch March 12, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] User, Log, Task Validator 분리
2 participants