[Refactor] #294 - Redis 유저 조회 로직 개선 #295
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀PullRequest🚀
📟 관련 이슈
💻 작업 내용
userService.findById
를userService.findByIdWithCache
를 이용하여 Redis에 캐싱되어 있는 유저 정보를 사용하여 처리하도록 하였습니다.📝 리뷰 노트
[JMeter 성능 테스트 - 기존 Redis 로직이었을 때 in Local]
[JMeter 성능 테스트 - Redis 조회 로직을 제거했을 때 in Local]
로컬에서 테스트를 진행하였을 때 조회 API 10만 건에서 평균 13ms에서 11ms로 개선되었음을 확인하였습니다. 저희 서버 인프라 상 싱글 코어인만큼 성능 차이는 더 확연히 벌어질 것이라고 생각합니다.
모르는 부분이 있거나 이상한 점은 코드리뷰에 달아주세요 감사합니다 :)