Fix memory leak caused by objects not being cleaned up in visibility_compute #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-chaney
changed the title
jcpassy
changed the base branch from
develop
to
issues/memory-leak-visibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@geopavlakos noticed that the memory usage was extremely high when using the function visibility_compute inside of a training loop. I traced it back to visibility_destructor never being called to clean up the search tree that is created when it isn't supplied as an argument.
The output of the function doesn't seem to be dependent on the search tree, so I simply delete it right before the return if it wasn't supplied as an argument. If there's a different approach that you would like, I'd be more than happy to make any changes.
@geopavlakos has been testing this fix for a while now and it has been stable without any side effects.