Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making guide links work in Github Markdown rendering and in game. #91

Merged
merged 4 commits into from
Apr 8, 2018

Conversation

peschue
Copy link
Contributor

@peschue peschue commented Apr 8, 2018

  • ".md" endings were ignored in game only for registering pages, after this change, they are also ignored in link targets.
  • This makes it possible to follow the links in Github as well as in game.
  • Includes a script that adds ".md" to all link targets in the guide (removed in tree but present in repo just in case it can be useful later).
  • Added ".md" to all link targets in guide.
  • Tested in game.

If we use .md suffixes, in github we can follow the links in the
formatted Markdown.
To make the links work in game, we ignore the ".md" suffix.
@cout970 cout970 merged commit 0008c2c into Magneticraft-Team:1.12 Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants