Add self-bond filter condition when computing new set of collators #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Reif <Garandor@manta.network>
Garandor
added
C-bug
added 5 commits
March 14, 2023 15:44
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Garandor
requested review from
Dengjianping,
ferrell-code,
ghzlatarev and
zqhxuyuan
ghzlatarev
reviewed
Mar 16, 2023
added 3 commits
March 16, 2023 09:24
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
ferrell-code
previously approved these changes
Mar 16, 2023
Signed-off-by: Adam Reif <Garandor@manta.network>
ghzlatarev
previously approved these changes
Mar 16, 2023
ferrell-code
previously approved these changes
Mar 16, 2023
Signed-off-by: Adam Reif <Garandor@manta.network>
ferrell-code
previously approved these changes
Mar 16, 2023
ghzlatarev
previously approved these changes
Mar 16, 2023
Signed-off-by: Adam Reif <Garandor@manta.network>
ferrell-code
approved these changes
Mar 16, 2023
ghzlatarev
approved these changes
Mar 16, 2023
SupremoUGH
pushed a commit
that referenced
this pull request
Mar 17, 2023
…1043) Signed-off-by: SupremoUGH <francisco@manta.network>
ghzlatarev
pushed a commit
that referenced
this pull request
Apr 4, 2023
* new method Signed-off-by: SupremoUGH <francisco@manta.network> * checkpoint Signed-off-by: SupremoUGH <francisco@manta.network> * Add self-bond filter condition when computing new set of collators (#1043) Signed-off-by: SupremoUGH <francisco@manta.network> * everything compiles Signed-off-by: SupremoUGH <francisco@manta.network> * typo Signed-off-by: SupremoUGH <francisco@manta.network> * chore: add dense_initial_pull Signed-off-by: SupremoUGH <francisco@manta.network> * bring back initial_pull Signed-off-by: SupremoUGH <francisco@manta.network> * upgrade to 0.5.13 Signed-off-by: SupremoUGH <francisco@manta.network> * everything compiles Signed-off-by: SupremoUGH <francisco@manta.network> * fix cargo lock Signed-off-by: SupremoUGH <francisco@manta.network> --------- Signed-off-by: SupremoUGH <francisco@manta.network> Co-authored-by: Adam Reif <garandor@manta.network> Co-authored-by: Daniel <danielnickreal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will result in collators on calamari below 4M self-bond no longer being eligible to produce blocks.
parachain-stakingled to fewer-than-expected collators being selectedFollowup to #937
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-group to this PRA-andC-groups to this PRA-calamari,A-dolphinand/orA-mantaif your changes are meant for/impact either of these (CI depends on it)Files changedin the Github PR explorer.Situational Notes:
BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]items to check for any.