Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.0.4 #1044

Merged
merged 8 commits into from
Mar 17, 2023
Merged

Release 4.0.4 #1044

merged 8 commits into from
Mar 17, 2023

Conversation

Garandor
Copy link
Contributor

@Garandor Garandor commented Mar 16, 2023

Description

This release activates 4M KMA self-bond limit for all collators.


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@Garandor Garandor self-assigned this Mar 16, 2023
@Garandor Garandor added C-enhancement Category: An issue proposing an enhancement or a PR with one A-calamari Area: Issues and PRs related to the Calamari Runtime L-skip Log: Will be skipped on changelog generation labels Mar 16, 2023
Adam Reif added 3 commits March 16, 2023 14:57
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Adam Reif added 2 commits March 16, 2023 18:37
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor marked this pull request as ready for review March 17, 2023 00:06
@Dengjianping
Copy link
Contributor

And I think this version should be bumped as well.
https://github.com/Manta-Network/Manta/blob/release-v4.0.4/.github/workflows/metadata_diff.yml#L7

Adam Reif added 3 commits March 16, 2023 22:01
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor
Copy link
Contributor Author

And I think this version should be bumped as well

Done and changed the release.md to catch these in the future. thx for pointing them out

@Garandor Garandor merged commit 50a1073 into manta Mar 17, 2023
@Garandor Garandor deleted the release-v4.0.4 branch March 17, 2023 19:27
@Garandor Garandor restored the release-v4.0.4 branch March 21, 2023 18:31
@Garandor Garandor mentioned this pull request Mar 21, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime C-enhancement Category: An issue proposing an enhancement or a PR with one L-skip Log: Will be skipped on changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants