Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable manta runtime xcm tests #1069

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Enable manta runtime xcm tests #1069

merged 2 commits into from
Apr 11, 2023

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Apr 11, 2023

Description

  • Add manta runtime xcm-mock module to run xcm tests in CI

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev self-assigned this Apr 11, 2023
@ghzlatarev ghzlatarev added C-bug Category: Issues documenting a bug A-manta Area: Issues and PRs related to the Manta Runtime A-runtime Area: Issues and PRs related to Runtimes A-testing Area: Testing-related Issues and PRs L-fixed Log: Issues and PRs related to bug fixes labels Apr 11, 2023
@ghzlatarev ghzlatarev marked this pull request as ready for review April 11, 2023 08:14
@github-actions
Copy link

github-actions bot commented Apr 11, 2023

⚠️ Congestion test: 1-day congestion cost (calamari) is NOT above target_daily_congestion_cost_kma

Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No integration test for manta in CI right now?

@ghzlatarev
Copy link
Contributor Author

No integration test for manta in CI right now?

i'll add them separately.

@Garandor
Copy link
Contributor

followup in #1070

@Garandor Garandor merged commit c348344 into manta Apr 11, 2023
@Garandor Garandor deleted the ghzlatarev/matna-xcm-tests branch April 11, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-manta Area: Issues and PRs related to the Manta Runtime A-runtime Area: Issues and PRs related to Runtimes A-testing Area: Testing-related Issues and PRs C-bug Category: Issues documenting a bug L-fixed Log: Issues and PRs related to bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants