Update Asset metadata call to not have dummy parameters #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles Ferrell <charlie@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
ferrell-code
added
A-manta
ferrell-code
changed the title
|
✅ Congestion test: 1-day congestion cost (manta-runtime) is above the target daily congestion cost |
|
|
Signed-off-by: Charles Ferrell <charlie@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
ferrell-code
requested review from
Dengjianping,
Garandor,
ghzlatarev and
zqhxuyuan
and removed request for
Dengjianping and
Garandor
ghzlatarev
reviewed
Aug 23, 2023
ghzlatarev
approved these changes
Aug 24, 2023
Dengjianping
approved these changes
Aug 29, 2023
ghzlatarev
added a commit
that referenced
this pull request
Sep 27, 2023
ghzlatarev
added a commit
that referenced
this pull request
Sep 27, 2023
* bump chainspec Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Update changelog Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * BUmp tx version Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Revert tx-version bump Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Revert #1236 Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * update changelog Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> --------- Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-group to this PRA-andC-groups to this PRA-calamariand/orA-mantaif your changes are meant for/impact either of these (CI depends on it)Files changedin the Github PR explorer.Situational Notes:
BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]items to check for any.