Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❇️ org arc-runner patch 1 #1240

Merged
merged 11 commits into from
Jul 31, 2023
Merged

❇️ org arc-runner patch 1 #1240

merged 11 commits into from
Jul 31, 2023

Conversation

anaye1997
Copy link
Contributor

@anaye1997 anaye1997 commented Jul 31, 2023

Description

this change replaces on demand self hosted runner with arc-runner


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@github-actions
Copy link

Please signoff on all commits with your name, email and gpg key for the Developer's Certificate of Origin.
git config --global user.name your_name
git config --global user.email you_email
COMMAND : git commit -s -S -m your_commit_message
-s = Signed-off-by
-S = Verify commit using gpg key
If there is more than one commit in your pull request and your git client is modern enough (2.13+), rebase the required number of commits with --signoff:
git rebase --signoff -S HEAD~<number_of_commits>
Then, force push:
git push -f origin <your_branch>
For instructions on managing gpg signature verification please visit: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Signed-off-by: Anathan (Ana) Ye <anaye@duck.com>
@anaye1997 anaye1997 added A-automation Area: Issues and PRs related to Automation L-added Log: Issues and PRs related to addition L-changed Log: Issues and PRs related to changes and removed L-changed Log: Issues and PRs related to changes labels Jul 31, 2023
…nner

Signed-off-by: Anathan (Ana) Ye <anaye@duck.com>
Signed-off-by: Anathan (Ana) Ye <anaye@duck.com>
Signed-off-by: Anathan (Ana) Ye <anaye@duck.com>
Signed-off-by: Anathan (Ana) Ye <anaye@duck.com>
Signed-off-by: Anathan (Ana) Ye <anaye@duck.com>
Signed-off-by: Anathan (Ana) Ye <anaye@duck.com>
Signed-off-by: Anathan (Ana) Ye <anaye@duck.com>
Signed-off-by: Anathan (Ana) Ye <anaye@duck.com>
Signed-off-by: Anathan (Ana) Ye <anaye@duck.com>
Signed-off-by: Anathan (Ana) Ye <anaye@duck.com>
@github-actions
Copy link

github-actions bot commented Jul 31, 2023

✅ Congestion test: 1-day congestion cost (manta-runtime) is above the target daily congestion cost

@github-actions
Copy link

github-actions bot commented Jul 31, 2023

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above the target daily congestion cost

@ghzlatarev ghzlatarev added A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime labels Jul 31, 2023
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Dengjianping Dengjianping merged commit ade6b36 into manta Jul 31, 2023
44 checks passed
@Dengjianping Dengjianping deleted the feature/arc-runner-patch-1 branch July 31, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-automation Area: Issues and PRs related to Automation A-calamari Area: Issues and PRs related to the Calamari Runtime A-manta Area: Issues and PRs related to the Manta Runtime L-added Log: Issues and PRs related to addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants