Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to manta-rs v0.5.9, switch to mainnet keys, fix ledger error handling #981

Merged
merged 8 commits into from
Jan 13, 2023

Conversation

SupremoUGH
Copy link
Contributor

@SupremoUGH SupremoUGH commented Jan 10, 2023

Signed-off-by: SupremoUGH francisco@manta.network

Description

Manta-rs v0.5.9 contains the calamari trusted setup keys

Added the improved error handling as in the latest commits of Manta-Network/manta-rs#294.

Disabled stress-test to be fixed in #984


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: SupremoUGH <francisco@manta.network>
@SupremoUGH SupremoUGH added A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-manta-pay Area: Issues and PRs related to the MantaPay Pallet L-changed Log: Issues and PRs related to changes labels Jan 10, 2023
Signed-off-by: SupremoUGH <francisco@manta.network>
@SupremoUGH SupremoUGH marked this pull request as ready for review January 10, 2023 20:10
CHANGELOG.md Outdated Show resolved Hide resolved
pallets/manta-pay/Cargo.toml Outdated Show resolved Hide resolved
pallets/manta-pay/src/lib.rs Outdated Show resolved Hide resolved
pallets/manta-pay/Cargo.toml Outdated Show resolved Hide resolved
pallets/manta-pay/src/lib.rs Outdated Show resolved Hide resolved
Signed-off-by: SupremoUGH <francisco@manta.network>
SupremoUGH and others added 2 commits January 11, 2023 14:22
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor changed the title Fix: Ledger error handling Upgrade to manta-rs v0.5.9, switch to mainnet keys, fix ledger error handling Jan 13, 2023
ghzlatarev
ghzlatarev previously approved these changes Jan 13, 2023
Garandor
Garandor previously approved these changes Jan 13, 2023
ferrell-code
ferrell-code previously approved these changes Jan 13, 2023
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev dismissed stale reviews from ferrell-code, Garandor, and themself via cb32561 January 13, 2023 17:42
ghzlatarev
ghzlatarev previously approved these changes Jan 13, 2023
Signed-off-by: Adam Reif <Garandor@manta.network>
Garandor
Garandor previously approved these changes Jan 13, 2023
ghzlatarev
ghzlatarev previously approved these changes Jan 13, 2023
ferrell-code
ferrell-code previously approved these changes Jan 13, 2023
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor dismissed stale reviews from ferrell-code, ghzlatarev, and themself via 47574ba January 13, 2023 21:11
@Garandor Garandor merged commit 56f8cb3 into manta Jan 13, 2023
@Garandor Garandor deleted the fix/errors-v2 branch January 13, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-manta Area: Issues and PRs related to the Manta Runtime A-manta-pay Area: Issues and PRs related to the MantaPay Pallet L-changed Log: Issues and PRs related to changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants