feat: merge abstract phase1 for trusted setup #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
There was a problem hiding this comment.
Looks good, I like the refactoring of Configuration into Pairing, Serializer, Deserializer, and HasDistribution.
I'm going to think a bit about whether it would make things clearer to refactor Response and Challenge so that only Response would be passed between functions and Challenge could be computed within the function that needs it. Maybe this isn't possible or worthwhile but I find the current usage confusing.
bhgomes
added
changelog:added
Co-authored-by: Todd Norton <93260651+GhostOfGauss@users.noreply.github.com> Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
For many proof system SRS ceremonies, we use a modified KZG scheme. Instead of having a global one, we wanted to have a Groth16-specific KZG ceremony, and in the future we can add a more universal interface for this commitment scheme SRS. Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
|
@GhostOfGauss Resurfacing this issue #131 (comment) since the code has changed since then. |
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Co-authored-by: Todd Norton <93260651+GhostOfGauss@users.noreply.github.com> Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
GhostOfGauss
previously approved these changes
Jul 8, 2022
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
BoyuanFeng
suggested changes
Jul 8, 2022
Co-authored-by: Boyuan Feng <bfeng9@wisc.edu> Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
BoyuanFeng
previously approved these changes
Jul 8, 2022
tsunrise
suggested changes
Jul 11, 2022
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
tsunrise
approved these changes
Jul 12, 2022
BoyuanFeng
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds preliminary phase1 abstractions for trusted setup, integrating into the rest of the
manta-rsecosystem.Before we can merge this PR, please make sure that all the following items have been checked off:
CHANGELOG.mdand added the appropriatechangeloglabel to the PR.Files changedin the GitHub PR explorer.CONTRIBUTING.md.