Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: simplify algebra APIs #132

Merged
merged 9 commits into from
Jun 27, 2022
Merged

fix: simplify algebra APIs #132

merged 9 commits into from
Jun 27, 2022

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Jun 24, 2022 •
edited
Loading

Simplify algebra APIs by removing ECC-specific designs.

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@bhgomes bhgomes added changelog:changed Changelog: add these changes to the `changed` section of the changelog norelease labels Jun 24, 2022
@bhgomes bhgomes self-assigned this Jun 24, 2022
@bhgomes bhgomes added this to the v0.5.2 milestone Jun 24, 2022
@bhgomes bhgomes marked this pull request as ready for review June 24, 2022 21:30
tsunrise
tsunrise suggested changes Jun 24, 2022
View reviewed changes
manta-pay/src/crypto/constraint/arkworks/mod.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/constraint/arkworks/mod.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
manta-crypto/src/algebra.rs Outdated Show resolved Hide resolved
@bhgomes bhgomes requested a review from tsunrise June 27, 2022 17:51
@bhgomes bhgomes mentioned this pull request Jun 27, 2022
Merged
4 tasks
@bhgomes bhgomes merged commit 0a796ab into main Jun 27, 2022
@bhgomes bhgomes deleted the fix/simplify-algebra branch June 27, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsunrise tsunrise tsunrise approved these changes

@BoyuanFeng BoyuanFeng BoyuanFeng approved these changes

Assignees

@bhgomes bhgomes

Labels
changelog:changed Changelog: add these changes to the `changed` section of the changelog
Projects
None yet
Milestone
v0.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@bhgomes @tsunrise @BoyuanFeng