Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cargo-sort to the CI pipeline #163

Merged
merged 3 commits into from
Jul 7, 2022
Merged

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Jul 7, 2022

  • Adds Cargo.toml dependency sorting to the CI pipeline
  • Uses standard workspace-hack as the name of the hack crate to reduce dependence on manta naming schemes
  • Resolves old clippy false positives

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@bhgomes bhgomes added changelog:added Changelog: add these changes to the `added` section of the changelog P-low Priority: Low A-ci Area: Continuous Integration labels Jul 7, 2022
@bhgomes bhgomes added this to the v0.5.3 milestone Jul 7, 2022
@bhgomes bhgomes linked an issue Jul 7, 2022 that may be closed by this pull request
@bhgomes bhgomes linked an issue Jul 7, 2022 that may be closed by this pull request
2 tasks
@bhgomes bhgomes merged commit 449d631 into main Jul 7, 2022
@bhgomes bhgomes deleted the feat/add-cargo-sort branch July 7, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: Continuous Integration changelog:added Changelog: add these changes to the `added` section of the changelog P-low Priority: Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cargo-sort to CI Clippy Tracking Issue
3 participants