Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/fixed base scalar multiplication using precomputed table #196

Merged
merged 16 commits into from
Aug 23, 2022
Merged

feat/fixed base scalar multiplication using precomputed table #196

merged 16 commits into from
Aug 23, 2022

Conversation

tsunrise
Copy link
Contributor

@tsunrise tsunrise commented Aug 8, 2022 •
edited
Loading

Add fixed base scalar multiplication using precomputed tables. This PR essentially restores #34

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.
  • Ran cargo hakari generate to update the workspace-hack system

@tsunrise tsunrise changed the title Feat/fixed base scalar mul feat/fixed base scalar multiplication Aug 8, 2022
@tsunrise tsunrise changed the title feat/fixed base scalar multiplication feat/fixed base scalar multiplication using precomputed table Aug 8, 2022
@tsunrise tsunrise added changelog:added Changelog: add these changes to the `added` section of the changelog A-cryptography Area: Issues and PRs related to Cryptography labels Aug 9, 2022
bhgomes
bhgomes suggested changes Aug 9, 2022
View reviewed changes
manta-crypto/src/lib.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-pay/src/lib.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
@tsunrise tsunrise requested a review from bhgomes August 9, 2022 19:12
bhgomes
bhgomes suggested changes Aug 9, 2022
View reviewed changes
manta-crypto/src/algebra.rs Outdated Show resolved Hide resolved
manta-crypto/src/arkworks/algebra.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
SupremoUGH
SupremoUGH suggested changes Aug 10, 2022
View reviewed changes
manta-crypto/src/arkworks/algebra.rs Outdated Show resolved Hide resolved
SupremoUGH
SupremoUGH previously approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@SupremoUGH SupremoUGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems alright now, approved!

@bhgomes
Merge branch 'main' into feat/fixed_base_scalar_mul
1ec531b 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@BoyuanFeng BoyuanFeng merged commit 0ab0ff2 into main Aug 23, 2022
@BoyuanFeng BoyuanFeng deleted the feat/fixed_base_scalar_mul branch August 23, 2022 19:13
@SupremoUGH SupremoUGH mentioned this pull request Aug 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhgomes bhgomes bhgomes approved these changes

@BoyuanFeng BoyuanFeng BoyuanFeng approved these changes

@SupremoUGH SupremoUGH SupremoUGH left review comments

Assignees
No one assigned
Labels
A-cryptography Area: Issues and PRs related to Cryptography changelog:added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tsunrise @bhgomes @BoyuanFeng @SupremoUGH