Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Trusted Setup Ceremony Primitives #238

Merged
merged 64 commits into from
Sep 23, 2022
Merged

feat: Trusted Setup Ceremony Primitives #238

merged 64 commits into from
Sep 23, 2022

Conversation

tsunrise
Copy link
Contributor

@tsunrise tsunrise commented Sep 4, 2022 •
edited by BoyuanFeng
Loading

Add client and server primitives for Trusted Setup Ceremony. This PR is part of #177.

  • Concrete Message Protocol
  • Coordinator
  • Client/Server library including network
  • Some small util changes
  • Concrete impl of manta_trusted_setup::groth16::ceremony::signature::SignatureScheme using ed25519 from manta-crypto

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@tsunrise tsunrise mentioned this pull request Sep 4, 2022
Closed
BoyuanFeng
BoyuanFeng reviewed Sep 6, 2022
View reviewed changes
manta-util/src/bytes.rs Outdated Show resolved Hide resolved
GhostOfGauss
GhostOfGauss reviewed Sep 19, 2022
View reviewed changes
Copy link
Contributor

@GhostOfGauss GhostOfGauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many places with only a couple words of documentation would benefit from a bit more explanation

manta-crypto/src/dalek/ed25519.rs Show resolved Hide resolved
manta-trusted-setup/src/ceremony/signature.rs Show resolved Hide resolved
manta-trusted-setup/src/ceremony/registry/csv.rs Show resolved Hide resolved
manta-trusted-setup/src/groth16/ceremony/message.rs Outdated Show resolved Hide resolved
manta-trusted-setup/src/groth16/ceremony/message.rs Outdated Show resolved Hide resolved
manta-trusted-setup/src/groth16/ceremony/server.rs Show resolved Hide resolved
manta-trusted-setup/src/groth16/ceremony/server.rs Show resolved Hide resolved
manta-trusted-setup/src/groth16/ceremony/server.rs Outdated Show resolved Hide resolved
manta-trusted-setup/src/groth16/ceremony/coordinator.rs Show resolved Hide resolved
manta-trusted-setup/src/groth16/ceremony/coordinator.rs Outdated Show resolved Hide resolved
@bhgomes
wip: commit save point
da3effc 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
wip: commit save point
5de8d41 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes marked this pull request as draft September 19, 2022 21:39
@bhgomes
wip: commit save point
bc81d08 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
wip: commit save point
8d83915 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
wip: commit save point
feeea85 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
wip: commit save point
c42bb86 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
wip: commit save point
b69677b 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
wip: commit save point
c8a59e9 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
wip: commit save point
ecb58f0 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
chore: finalize APIs
5d4dd28 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes marked this pull request as ready for review September 20, 2022 13:00
GhostOfGauss
GhostOfGauss reviewed Sep 20, 2022
View reviewed changes
manta-trusted-setup/src/groth16/ceremony/coordinator.rs Show resolved Hide resolved
manta-trusted-setup/src/groth16/ceremony/coordinator.rs Show resolved Hide resolved
manta-trusted-setup/src/groth16/ceremony/coordinator.rs Outdated Show resolved Hide resolved
manta-trusted-setup/src/groth16/ceremony/server.rs Show resolved Hide resolved
manta-util/src/collections/vec_deque.rs Outdated Show resolved Hide resolved
manta-trusted-setup/src/groth16/ceremony/config/ppot.rs Show resolved Hide resolved
manta-trusted-setup/src/groth16/ceremony/config/ppot.rs Show resolved Hide resolved
manta-trusted-setup/src/groth16/ceremony/config/ppot.rs Outdated Show resolved Hide resolved
manta-trusted-setup/src/groth16/ceremony/client.rs Outdated Show resolved Hide resolved
@bhgomes bhgomes added the P-high Priority: High label Sep 20, 2022
@bhgomes
fix: address some review comments
2e22efe 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
bhgomes and others added 2 commits September 22, 2022 13:24
@bhgomes @GhostOfGauss
Apply suggestions from code review
55df7f3 
Co-authored-by: Todd Norton <93260651+GhostOfGauss@users.noreply.github.com>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
fix: address comments
576e45d 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
chore: update workspace
e448a1d 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
GhostOfGauss
GhostOfGauss approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@GhostOfGauss GhostOfGauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and I like the Parallel, Rounds design, much clearer

@bhgomes bhgomes merged commit d653f87 into main Sep 23, 2022
@bhgomes bhgomes deleted the feat/ts_ceremony branch September 23, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoyuanFeng BoyuanFeng BoyuanFeng approved these changes

@GhostOfGauss GhostOfGauss GhostOfGauss approved these changes

@bhgomes bhgomes Awaiting requested review from bhgomes

Assignees

@tsunrise tsunrise

@BoyuanFeng BoyuanFeng

Labels
A-development Area: Development Resources and Upgrades changelog:added Changelog: add these changes to the `added` section of the changelog P-high Priority: High
Projects
None yet
Milestone
v0.5.5
Development

Successfully merging this pull request may close these issues.
4 participants
@tsunrise @bhgomes @BoyuanFeng @GhostOfGauss