Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: upgrade asset system #283

Merged
merged 25 commits into from
Nov 22, 2022
Merged

Feat: upgrade asset system #283

merged 25 commits into from
Nov 22, 2022

Conversation

SupremoUGH
Copy link
Contributor

@SupremoUGH SupremoUGH commented Nov 15, 2022

Third part of #153. It consists of the changes related to the asset system. To be merged after #282.

Changes:
manta-util:

  • codec.rs: Decode implementation for u128.

manta-accounting:

  • asset.rs: Upgrade to the new asset system. Now Asset is more general and depends on two generics.
  • transfer: Included the associated types AssetId and AssetValue in the Configuration trait.
  • rest of manta-accounting: Minimal changes so it compiles.

manta-pay:

  • config: Concrete implementations of AssetId and AssetValue for Config, with the relevant trait implementations.
  • rest of manta-pay: minimal changes so it compiles.

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH SupremoUGH added changelog:changed Changelog: add these changes to the `changed` section of the changelog P-high Priority: High labels Nov 16, 2022
@SupremoUGH SupremoUGH self-assigned this Nov 16, 2022
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH SupremoUGH marked this pull request as ready for review November 16, 2022 17:44
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
GhostOfGauss
GhostOfGauss previously approved these changes Nov 18, 2022
manta-accounting/src/asset.rs Show resolved Hide resolved
manta-accounting/src/asset.rs Show resolved Hide resolved
manta-accounting/src/asset.rs Show resolved Hide resolved
manta-accounting/src/asset.rs Show resolved Hide resolved
manta-pay/src/config.rs Outdated Show resolved Hide resolved
@GhostOfGauss
Copy link
Contributor

@bhgomes do you know why the CI Lint check is skipping?

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
Copy link
Contributor

bhgomes commented Nov 18, 2022

@bhgomes do you know why the CI Lint check is skipping?

Not really sure why, will have to investigate. Probably it's timing out or overusing resources.

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes merged commit b45ecb5 into main Nov 22, 2022
@bhgomes bhgomes deleted the feat/new-circuits-asset branch November 22, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:changed Changelog: add these changes to the `changed` section of the changelog P-high Priority: High
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants