Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MantaPay v1 #286

Merged
merged 36 commits into from
Dec 3, 2022
Merged

MantaPay v1 #286

merged 36 commits into from
Dec 3, 2022

Conversation

SupremoUGH
Copy link
Contributor

@SupremoUGH SupremoUGH commented Nov 24, 2022

Last part of #153. It consists of the changes related to the transfer protocol and the signer.

Changes:
manta-util:

  • codec.rs: Encode implementation for manta_util::Array.
  • num.rs: CheckedAdd implementation for references of types implementing CheckedAdd. Same for CheckedSub.

manta-crypto:

  • arkworks::algebra: moved ScalarVar, Group, and GroupVar and their trait implementations here.
  • constraint: Added division with remainder utilities.
  • encryption: Fixed error in Constant implementation for UnsafeNoEncrypt.

manta-accounting:

  • asset.rs: Weakened the assumptions for HashAssetMap and BTreeAssetMap.
  • transfer: Upgrade to new transfer protocol.
  • wallet: Upgrade signer.

manta-pay:

  • crypto::ecc: Deleted and moved to manta-crypto.
  • crypto::poseidon::arkworks: Fixed error in BlockElement implementation for FpVar.
  • crypto::poseidon::encryption: Fixed error in Write implementation for CiphertextBlock. Added Decode and Encode implementations for FixedEncryption.
  • crypto::poseidon: Implementations for State.
  • config: Concrete implementations of transfer::Configuration and protocol::Configuration in mod and utxo, respectively.
  • signer: Upgrade to the new signer.
  • test and simulation: new testing suite and simulation for the new protocol.

manta-parameters and manta-pay::parameters:

  • update the parameters to the new protocol.

manta-benchmark:

  • benchmarking suite for ToPrivate, PrivateTransfer and ToPublic proof generation and verification.

TODO:

  • Revisit the re-implementations of Sample (which I might have to undo).
  • Update the branch in manta-parameters to main.
  • Move some tests in manta-accounting to manta-pay (if possible).

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH SupremoUGH added changelog:added Changelog: add these changes to the `added` section of the changelog P-high Priority: High labels Nov 29, 2022
@SupremoUGH SupremoUGH marked this pull request as ready for review November 29, 2022 20:51
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
manta-util/src/num.rs Outdated Show resolved Hide resolved
SupremoUGH and others added 8 commits December 1, 2022 12:49
Co-authored-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Francisco Hernández Iglesias <38819712+SupremoUGH@users.noreply.github.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
bhgomes
bhgomes previously approved these changes Dec 1, 2022
@SupremoUGH SupremoUGH mentioned this pull request Dec 2, 2022
9 tasks
manta-accounting/src/transfer/utxo/protocol.rs Outdated Show resolved Hide resolved
manta-accounting/src/transfer/mod.rs Outdated Show resolved Hide resolved
manta-accounting/src/transfer/mod.rs Outdated Show resolved Hide resolved
manta-accounting/src/transfer/mod.rs Outdated Show resolved Hide resolved
manta-accounting/src/transfer/mod.rs Show resolved Hide resolved
manta-pay/src/config/poseidon.rs Show resolved Hide resolved
manta-pay/src/config/utxo.rs Show resolved Hide resolved
manta-pay/src/config/mod.rs Show resolved Hide resolved
manta-pay/src/config/utxo.rs Show resolved Hide resolved
manta-pay/src/config/utxo.rs Show resolved Hide resolved
Co-authored-by: Todd Norton <93260651+GhostOfGauss@users.noreply.github.com>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
bhgomes
bhgomes previously approved these changes Dec 3, 2022
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes merged commit 6572219 into main Dec 3, 2022
@bhgomes bhgomes deleted the feat/mantapay-v1 branch December 3, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:added Changelog: add these changes to the `added` section of the changelog P-high Priority: High
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants