Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction data methods #295

Merged
merged 14 commits into from
Jan 12, 2023
Merged

Transaction data methods #295

merged 14 commits into from
Jan 12, 2023

Conversation

SupremoUGH
Copy link
Contributor

@SupremoUGH SupremoUGH commented Dec 19, 2022 •
edited by bhgomes
Loading

  • Adds methods to request transaction data, i.e. transaction kind (ToPrivate, PrivateTransfer and ToPublic), Identifier and Asset from the signer.
  • Adds methods to verify the validity of given transaction data.

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@SupremoUGH
transaction data method
a3b41eb
@SupremoUGH
transactiondata interface
ae3a819
@SupremoUGH
changelog
7f8aab0 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH SupremoUGH added changelog:added Changelog: add these changes to the `added` section of the changelog A-cryptography Area: Issues and PRs related to Cryptography A-compatibility Area: Issues and PRs related to Compatibility labels Dec 19, 2022
@SupremoUGH
docs typo
a7c8a22 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH SupremoUGH changed the title transaction data method Transaction data methods Dec 19, 2022
@SupremoUGH
docs
e1ad905 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH SupremoUGH marked this pull request as ready for review December 19, 2022 19:38
This was referenced Dec 25, 2022
Draft
Draft
@bhgomes bhgomes requested review from Apokalip and removed request for AlexParshh January 10, 2023 15:59
bhgomes
bhgomes previously approved these changes Jan 10, 2023
View reviewed changes
@bhgomes
chore: address review comments
29a4a59 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
bhgomes
bhgomes previously approved these changes Jan 10, 2023
View reviewed changes
zqhxuyuan
zqhxuyuan previously approved these changes Jan 11, 2023
View reviewed changes
@bhgomes bhgomes dismissed stale reviews from zqhxuyuan and themself via b31072a January 12, 2023 03:08
@bhgomes bhgomes merged commit 0787666 into main Jan 12, 2023
@bhgomes bhgomes deleted the retrieve_transaction_data branch January 12, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhgomes bhgomes bhgomes approved these changes

@Apokalip Apokalip Awaiting requested review from Apokalip

@zqhxuyuan zqhxuyuan Awaiting requested review from zqhxuyuan

Assignees
No one assigned
Labels
A-compatibility Area: Issues and PRs related to Compatibility A-cryptography Area: Issues and PRs related to Cryptography changelog:added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SupremoUGH @zqhxuyuan @bhgomes @AlexParshh