Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: verifying key serialization #304

Merged
merged 6 commits into from
Jan 12, 2023
Merged

fix: verifying key serialization #304

merged 6 commits into from
Jan 12, 2023

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Jan 12, 2023 •
edited
Loading

Fixes verifying key serialization for trusted setup parameters.

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@bhgomes
wip: add fix for verifying contexts
ff66b83 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
fix: use correct bounds for serialization
7e3fe7b 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
chore: upload last round trusted setup state
95d73db 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
wip: recompute verifying keys
1851eb7 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes added changelog:skip Changelog: skip adding these changes to the changelog changelog:fixed Changelog: add these changes to the `fixed` section of the changelog and removed changelog:skip Changelog: skip adding these changes to the changelog labels Jan 12, 2023
@bhgomes
chore: remove circuit names file
396ad3f 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
chore: add ignored test
3c9b567 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes marked this pull request as ready for review January 12, 2023 19:38
@bhgomes bhgomes merged commit e657b16 into main Jan 12, 2023
@bhgomes bhgomes deleted the fix/verifying-key branch January 12, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GhostOfGauss GhostOfGauss GhostOfGauss approved these changes

@BoyuanFeng BoyuanFeng Awaiting requested review from BoyuanFeng

Assignees
No one assigned
Labels
changelog:fixed Changelog: add these changes to the `fixed` section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhgomes @GhostOfGauss