Generalize Wallets and Fix Receiving Key Encoding #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhgomes
changed the title
stechu
approved these changes
Mar 10, 2022
tsunrise
pushed a commit
that referenced
this pull request
Mar 18, 2022
* feat: generalize simulation to all wallets * fix: use correct feature requirements for simulation * fix: use correct receiving key encoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalizes simulation for all wallets of the form
Wallet<C, L, S>for whereCis the transfer configuration,Lis the ledger connection, andSis the signer connection. This allows for testing with more interaction complexity like substrate in-memory ledger, full node ledger, full signer, etc. To build your own simulation see how themanta-pay/src/simulation/mod.rsfile runs the new generalized simulation and copy the overall pattern.The receiving key encoding is the following: