Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync protocol optimization #357

Merged
merged 44 commits into from
Jun 20, 2023
Merged

Sync protocol optimization #357

merged 44 commits into from
Jun 20, 2023

Conversation

SupremoUGH
Copy link
Contributor

@SupremoUGH SupremoUGH commented Jun 15, 2023 •
edited
Loading

Implements the batch insertion algorithm when you merge a branch onto the base of a ForkedTree. Closes #354

To be merged after: #356
and #355

Goes together with Manta-Network/sdk#133

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@SupremoUGH SupremoUGH self-assigned this Jun 15, 2023
@SupremoUGH SupremoUGH added changelog:changed Changelog: add these changes to the `changed` section of the changelog A-performance Area: Performance-related Issues and PRs A-cryptography Area: Issues and PRs related to Cryptography labels Jun 15, 2023
@SupremoUGH SupremoUGH marked this pull request as ready for review June 15, 2023 16:04
@SupremoUGH SupremoUGH mentioned this pull request Jun 15, 2023
Merged
3 tasks
@SupremoUGH SupremoUGH mentioned this pull request Jun 20, 2023
Open
@SupremoUGH SupremoUGH merged commit 326b582 into main Jun 20, 2023
@SupremoUGH SupremoUGH deleted the sync_protocol_optimization branch June 20, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apokalip Apokalip Apokalip approved these changes

@ghzlatarev ghzlatarev ghzlatarev approved these changes

@zqhxuyuan zqhxuyuan Awaiting requested review from zqhxuyuan

Assignees

@SupremoUGH SupremoUGH

Labels
A-cryptography Area: Issues and PRs related to Cryptography A-performance Area: Performance-related Issues and PRs changelog:changed Changelog: add these changes to the `changed` section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize extend_with_marked_digests
3 participants
@SupremoUGH @Apokalip @ghzlatarev