Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve ledger API flexibility and encoding #59

Merged
merged 3 commits into from
May 5, 2022
Merged

feat: improve ledger API flexibility and encoding #59

merged 3 commits into from
May 5, 2022

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented May 4, 2022 •
edited
Loading

  • Improve access to the PullResponse type to algorithms that don't need to implement the entire ledger::Connection trait
  • Add SCALE codec to Checkpoint

@bhgomes bhgomes marked this pull request as ready for review May 4, 2022 19:15
@bhgomes bhgomes requested a review from Kevingislason May 4, 2022 19:15
@bhgomes bhgomes changed the title feat: separate pull configuration from ledger connection feat: improve ledger API flexibility and encoding May 5, 2022
@bhgomes bhgomes requested review from stechu, BoyuanFeng and a user May 5, 2022 20:08
@stechu stechu merged commit c1e46ad into main May 5, 2022
@stechu stechu deleted the feat/flexible-ledger-api branch May 5, 2022 21:12
BoyuanFeng pushed a commit that referenced this pull request Jun 2, 2022
@bhgomes
feat: improve ledger API flexibility and encoding (#59)
52a44dd 
* feat: separate pull configuration from ledger connection

* feat: add raw checkpoint

* feat: expose serde_with in public API for manta-util
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stechu stechu stechu approved these changes

@Kevingislason Kevingislason Awaiting requested review from Kevingislason

@BoyuanFeng BoyuanFeng Awaiting requested review from BoyuanFeng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhgomes @stechu