Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/benchmark #63

Merged
merged 10 commits into from
May 12, 2022
Merged

Feat/benchmark #63

merged 10 commits into from
May 12, 2022

Conversation

BoyuanFeng
Copy link
Contributor

Implement a native benchmark for manta-pay: mint, private transfer, and reclaim.

bhgomes
bhgomes suggested changes May 9, 2022
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
manta-benchmark/Cargo.toml Outdated Show resolved Hide resolved
manta-benchmark/benches/bench_mint.rs Outdated Show resolved Hide resolved
manta-benchmark/benches/bench_mint.rs Outdated Show resolved Hide resolved
manta-benchmark/src/payment.rs Outdated Show resolved Hide resolved
manta-benchmark/src/payment.rs Outdated Show resolved Hide resolved
manta-benchmark/src/payment.rs Outdated Show resolved Hide resolved
manta-benchmark/src/payment.rs Outdated Show resolved Hide resolved
manta-benchmark/src/payment.rs Outdated Show resolved Hide resolved
manta-benchmark/Cargo.toml Outdated Show resolved Hide resolved
bhgomes
bhgomes suggested changes May 10, 2022
View reviewed changes
Copy link
Contributor

@bhgomes bhgomes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your great PR! Just need to resolve a few nits and then we can merge.

Also, I forgot to add that you can actually remove the anyhow dependency from the manta-pay library since the error type is simple in the new code.

manta-benchmark/benches/mint.rs Outdated Show resolved Hide resolved
manta-benchmark/benches/mint.rs Outdated Show resolved Hide resolved
manta-pay/Cargo.toml Outdated Show resolved Hide resolved
manta-pay/Cargo.toml Outdated Show resolved Hide resolved
manta-pay/src/lib.rs Outdated Show resolved Hide resolved
manta-benchmark/src/payment.rs Outdated Show resolved Hide resolved
manta-benchmark/benches/reclaim.rs Outdated Show resolved Hide resolved
manta-benchmark/benches/reclaim.rs Outdated Show resolved Hide resolved
manta-benchmark/benches/private_transfer.rs Outdated Show resolved Hide resolved
manta-benchmark/benches/private_transfer.rs Outdated Show resolved Hide resolved
@bhgomes bhgomes merged commit 57e3de1 into main May 12, 2022
@bhgomes bhgomes deleted the feat/benchmark branch May 12, 2022 16:22
BoyuanFeng pushed a commit that referenced this pull request Jun 2, 2022
feat: add benchmarks (#63)
baa3c4b 
* feat: add proving and verifying benchmark
* fix: remove let bindings for clippy false positives
Co-authored-by: Brandon H. Gomes <bhgomes@pm.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhgomes bhgomes bhgomes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BoyuanFeng @bhgomes