feat(ci): add binary compatiblity test #90

tsunrise · 2022-06-08T20:45:19Z

Summary

Add test to support binary compatibility of UTXO.

Details

This PR ports the hardcoded test from https://github.com/Manta-Network/Manta/blob/manta/pallets/manta-pay/src/bin/precompute_coins.rs. This test makes sure changes in current PR are still compatible with the UTXO versions in manta-sdk.

Closes: #89

Before we can merge this PR, please make sure that all the following items have been checked off:

Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
Re-reviewed Files changed in the GitHub PR explorer.
Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

* feat: add documentation for contributing * fix: update logo spacing and correct formatting for bullets * feat: update CHANGELOG to include current changes * fix: use full paths for CHANGELOG and CONTRIBUTING links * fix: correct Github -> GitHub typo * feat: add automatic tag-and-release pipeline * feat: add label descriptions in CONTRIBUTING.md * fix: update PULL_REQUEST_TEMPLATE links Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

Signed-off-by: Tom Shen <me@tomshen.io>

manta-pay/Cargo.toml

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

manta-pay/Cargo.toml

manta-pay/src/test/compat.rs

manta-pay/src/test/mod.rs

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

manta-pay/src/test/mod.rs

manta-pay/src/lib.rs

manta-pay/src/test/compat.rs

manta-pay/src/lib.rs

manta-pay/Cargo.toml

manta-pay/src/test/compatibility.rs

we resolved the issue

tsunrise requested review from bhgomes, BoyuanFeng and stechu June 8, 2022 20:46

tsunrise changed the title ~~Add binary compatiblity test~~ ci: Add Binary Compatiblity Test Jun 8, 2022

bhgomes added this to the v1.0.0 milestone Jun 9, 2022

bhgomes changed the title ~~ci: Add Binary Compatiblity Test~~ feat(ci): add binary compatiblity test Jun 9, 2022

tsunrise self-assigned this Jun 9, 2022

tsunrise added changelog:added Changelog: add these changes to the `added` section of the changelog norelease labels Jun 9, 2022

tsunrise and others added 4 commits June 9, 2022 13:34

feat: add binary compatibility test

72fc388

chore: nit

3ffd47f

chore: update CHANGELOG.md

b729f00

tsunrise force-pushed the ci/bin-compat branch from 536eb1d to b729f00 Compare June 9, 2022 20:35

tsunrise and others added 2 commits June 9, 2022 13:36

Merge branch 'main' into ci/bin-compat

928a3c7

Signed-off-by: Tom Shen <me@tomshen.io>

Merge branch 'main' into ci/bin-compat

6d1190c

stechu previously requested changes Jun 9, 2022

View reviewed changes

manta-pay/Cargo.toml Outdated Show resolved Hide resolved

Merge branch 'main' into ci/bin-compat

4c1d847

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

bhgomes mentioned this pull request Jun 13, 2022

Move Concrete Parameter Definitions Here #100

Closed

6 tasks

bhgomes modified the milestones: v1.0.0, v0.6.0 Jun 14, 2022

BoyuanFeng suggested changes Jun 14, 2022

View reviewed changes

Boyuan Feng and others added 5 commits June 14, 2022 16:10

fix: refactor shared prove&verify code

4a4862a

fix: update formats, cfg, and dependency versions

2929ce2

Merge branch 'main' into ci/bin-compat

7720691

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

fix: change sdk to manta-parameters

4b7a414

fix: format

94293fc

bhgomes suggested changes Jun 15, 2022

View reviewed changes

manta-pay/src/test/mod.rs Outdated Show resolved Hide resolved

manta-pay/src/lib.rs Outdated Show resolved Hide resolved

bhgomes reviewed Jun 15, 2022

View reviewed changes

manta-pay/src/test/compat.rs Outdated Show resolved Hide resolved

fix: file names

e3e5141

Boyuan Feng added 2 commits June 15, 2022 17:11

fix: refactor payment.rs

2fe6195

fix: require "groth16" feature for payment

efeec47

BoyuanFeng self-assigned this Jun 15, 2022