Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update parameter path from SDK to manta-parameters #119

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

BoyuanFeng
Copy link
Contributor

@BoyuanFeng BoyuanFeng commented Jun 20, 2022

Description

Parameters have been moved from SDK to manta-parameters, including ProvingContext, VerifyingContext, Parameters, and UtxoAccumulatorModel. We need to update the parameter path correspondingly in manta-signer.

closes: #118


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Test following procedure in docs/testing-workflow.md
  • Updated relevant documentation in the code.
  • Re-reviewed Files changed in the Github PR explorer.
  • Update the version numbers properly:
    • Cargo.toml
    • ui/package.json
    • ui/public/about.html
    • ui/src-tauri/Cargo.toml
    • ui/src-tauri/tauri.conf.json
    • www/src/App.tsx

@BoyuanFeng BoyuanFeng added the L-added Changelog: add these changes to the `added` section of the changelog label Jun 20, 2022
@BoyuanFeng BoyuanFeng added this to the v0.7.2 milestone Jun 20, 2022
@vercel
Copy link

vercel bot commented Jun 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
manta-signer ✅ Ready (Inspect) Visit Preview Jun 20, 2022 at 10:04PM (UTC)

@BoyuanFeng BoyuanFeng merged commit b2e9f5d into main Jun 21, 2022
@BoyuanFeng BoyuanFeng deleted the feat/parameters branch June 21, 2022 14:30
@bhgomes bhgomes added L-changed Changelog: add these changes to the `changed` section of the changelog and removed L-added Changelog: add these changes to the `added` section of the changelog labels Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L-changed Changelog: add these changes to the `changed` section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update parameter path from SDK to manta-parameters
2 participants